Skip to content

CLDSRV-890: Log lifecycle expiration events in server access logs#6150

Open
dvasilas wants to merge 2 commits intodevelopment/9.2from
improvement/CLDSRV-890-log-lifecycle-expiration-events
Open

CLDSRV-890: Log lifecycle expiration events in server access logs#6150
dvasilas wants to merge 2 commits intodevelopment/9.2from
improvement/CLDSRV-890-log-lifecycle-expiration-events

Conversation

@dvasilas
Copy link
Copy Markdown
Contributor

@dvasilas dvasilas commented Apr 14, 2026 •
edited
Loading

Add lifecycle expiration deletions to access logs.

For lifecycle expiration events:

  • Operation: S3.EXPIRE.OBJECT
  • Requester: ScalityS3LifecycleService
  • ClientIP/httpCode/timing/auth: undefined (log-courier will write - or "-")

Test plan

  • Add lifecycle expiration to workbench
  • Add end-to-end tests in log-courier

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 14, 2026

Hello dvasilas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 14, 2026

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@claude
Copy link
Copy Markdown

claude bot commented Apr 14, 2026

LGTM

Review by Claude Code

dvasilas added 2 commits April 17, 2026 18:22
@dvasilas
CLDSRV-890: Log lifecycle expiration events in server access logs
37eb8c1 
Lifecycle expiration deletions were suppressed from access logs.
Add an expiration flag to distinguish them from other backbeat
operations.
For lifecycle expiration events:
- Operation: S3.EXPIRE.OBJECT
- Requester: ScalityS3LifecycleService
- ClientIP/httpCode/timing/auth: undefined (log-courier will write
  - or "-")
@dvasilas
CLDSRV-890: Bump version to 9.2.37
b90440f
@dvasilas dvasilas force-pushed the improvement/CLDSRV-890-log-lifecycle-expiration-events branch from 121d19d to b90440f Compare April 17, 2026 15:23
@claude
Copy link
Copy Markdown

claude bot commented Apr 17, 2026

LGTM

Review by Claude Code

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.32%. Comparing base (c1d3d6a) to head (b90440f).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/routes/routeBackbeat.js 60.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/utilities/serverAccessLogger.js 83.40% <100.00%> (+1.38%) ⬆️
lib/routes/routeBackbeat.js 76.73% <60.00%> (-0.12%) ⬇️

... and 1 file with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.2    #6150      +/-   ##
===================================================
+ Coverage            84.29%   84.32%   +0.02%     
===================================================
  Files                  204      204              
  Lines                13151    13175      +24     
===================================================
+ Hits                 11086    11110      +24     
  Misses                2065     2065
Flag Coverage Δ
file-ft-tests 67.59% <20.83%> (-0.10%) ⬇️
kmip-ft-tests 28.20% <4.16%> (-0.05%) ⬇️
mongo-v0-ft-tests 68.85% <20.83%> (-0.07%) ⬇️
mongo-v1-ft-tests 68.81% <20.83%> (-0.09%) ⬇️
multiple-backend 35.27% <20.83%> (-0.03%) ⬇️
sur-tests 35.71% <4.16%> (-0.06%) ⬇️
sur-tests-inflights 37.55% <4.16%> (-0.10%) ⬇️
unit 69.99% <83.33%> (+0.02%) ⬆️
utapi-v2-tests 34.48% <4.16%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anurag4DSB anurag4DSB anurag4DSB approved these changes

@BourgoisMickael BourgoisMickael BourgoisMickael approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dvasilas @bert-e @anurag4DSB @BourgoisMickael